<html>
<head><meta charset="utf-8"><title>env variables in perf collector · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/env.20variables.20in.20perf.20collector.html">env variables in perf collector</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="201729923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/env%20variables%20in%20perf%20collector/near/201729923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/env.20variables.20in.20perf.20collector.html#201729923">(Jun 23 2020 at 14:05)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> is there a reason why <a href="https://github.com/rust-lang/rustc-perf/blob/b1f6c4d5cfa0b8e0ebf6d638310084511baca41b/collector/src/bin/rustc-perf-collector/execute.rs#L235">this line</a> exists in perf? </p>
<p>I'm doing some profiling locally and because I'm running in NixOS/a Nix shell, there are variables like <code>PKG_CONFIG_PATH</code> and <code>NIX_CFLAGS_COMPILE</code> that are totally necessary for anything to compile at all (e.g. for <code>libX11</code> to be found by <code>script-servo</code>'s build) - and this line is causing issues in that regard. </p>
<p>I assume other compiler folks have ran into this and have a workaround, I know that a surprising amount of folks are using Nix.</p>



<a name="201730086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/env%20variables%20in%20perf%20collector/near/201730086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/env.20variables.20in.20perf.20collector.html#201730086">(Jun 23 2020 at 14:06)</a>:</h4>
<p>It was intended to avoid things like rustflags or other locally-set things leaking in; I forget the particulars now, and there may never have been an actual example of something that broke without it</p>



<a name="201730234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/env%20variables%20in%20perf%20collector/near/201730234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/env.20variables.20in.20perf.20collector.html#201730234">(Jun 23 2020 at 14:07)</a>:</h4>
<p>right, that makes sense</p>



<a name="201733046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/env%20variables%20in%20perf%20collector/near/201733046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/env.20variables.20in.20perf.20collector.html#201733046">(Jun 23 2020 at 14:28)</a>:</h4>
<p>would you be open to a PR which changes this behaviour? </p>
<p>(personally, I was hoping to use <code>RUSTFLAGS</code> to toggle between <code>-Zpolymorphize=on/off</code> after I got this building anyway)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>